Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an experimental switch to disable font ligatures #2166

Closed
wants to merge 1 commit into from

Conversation

Simon-Laux
Copy link
Member

https://support.delta.chat/t/disabling-font-ligatures/1490

we could also think about changing the default, I'm not sure what option is better.

@Simon-Laux Simon-Laux added the enhancement New feature or request label Mar 6, 2021
@Simon-Laux Simon-Laux requested a review from Jikstra March 6, 2021 14:27
@Jikstra
Copy link
Contributor

Jikstra commented Mar 6, 2021

Is there any problem with just disabling font ligature? Don't like the idea of adding an option for something so subtle.

@r10s
Copy link
Member

r10s commented Mar 6, 2021

there was a single request in the issue tracker at #2106, the forum entry seems to be from the same user (nb: what is the exact issue? not-so-nice-looking? accessibility? unexpected?)

however, tbh, i would also not add such an option, at least not to the official settings and not in the usual "settings" dialog, not even as "experimental". that will come at cost, i do not think, this is worth maintaining currently.

i would also be careful with letting users change the font; that can easily led to issues wrt unicode etc. that looks as if it is a bug from our side. there are much "larger" apps not having something like that. if someone is uncomfortable with the system font and the ligatures used, we should point him to changing this in the system settings or options (of course, we should make sure to pick up the system font correctly).

@r10s
Copy link
Member

r10s commented Mar 6, 2021

i just checked signal and telegram desktop apps: i did not find such an option, but both seems to have ligatures disabled, at least if i type in fi that looks differently there. so, maybe, that is the more straight forward approach. however, compared to other things, i think, this is a really tiny detail :)

@Simon-Laux
Copy link
Member Author

so we are for disabling it in general?

@Simon-Laux
Copy link
Member Author

superseded by #2167

@Simon-Laux Simon-Laux closed this Mar 9, 2021
@r10s
Copy link
Member

r10s commented Mar 9, 2021

so we are for disabling it in general?

if there are really issues with ligatures, i think, this is the better approach, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants